refactor: PVS-Studio warnings fixes

src/content/Content.hpp

@@ -59,13 +59,25 @@ public:
     ContentUnitIndices(std::vector<T*> defs) : defs(std::move(defs)) {
     }
 
-    inline T* get(blockid_t id) const {
+    inline const T* get(blockid_t id) const {
         if (id >= defs.size()) {
             return nullptr;
         }
         return defs[id];
     }
 
+    [[deprecated]]
+    inline T* getWriteable(blockid_t id) const { // TODO: remove
+        if (id >= defs.size()) {
+            return nullptr;
+        }
+        return defs[id];
+    }
+
+    inline const T& require(blockid_t id) const {
+        return *defs.at(id);
+    }
+
     inline size_t count() const {
         return defs.size();
     }

src/content/ContentPack.cpp

@@ -132,11 +132,7 @@ fs::path ContentPack::findPack(
     if (fs::is_directory(folder)) {
         return folder;
     }
-    folder = paths->getResources() / fs::path("content") / fs::path(name);
-    if (fs::is_directory(folder)) {
-        return folder; //-V523
-    }
-    return folder; // FIXME: V523 The 'then' statement is equivalent to the subsequent code fragment //-V523
+    return paths->getResources() / fs::path("content") / fs::path(name);
 }
 
 ContentPackRuntime::ContentPackRuntime(ContentPack info, scriptenv env)