From 2cd6837da93da71e4a2913b717281462b60be84a Mon Sep 17 00:00:00 2001 From: Vyacheslav Ivanov Date: Sat, 3 Aug 2024 20:03:34 +0300 Subject: [PATCH] fix: optimization: PVS-Studio warning V836 Signed-off-by: Vyacheslav Ivanov --- src/graphics/ui/gui_xml.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/graphics/ui/gui_xml.cpp b/src/graphics/ui/gui_xml.cpp index dc7fdc59..8c61e2e8 100644 --- a/src/graphics/ui/gui_xml.cpp +++ b/src/graphics/ui/gui_xml.cpp @@ -203,7 +203,7 @@ static void _readPanel(UiXmlReader& reader, const xml::xmlelement& element, Pane panel.setMaxLength(element->attr("max-length").asInt()); } if (element->has("orientation")) { - auto oname = element->attr("orientation").getText(); + auto &oname = element->attr("orientation").getText(); if (oname == "horizontal") { panel.setOrientation(Orientation::horizontal); }