PulseStudio/VoxelEngine
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: optimization: PVS-Studio warning V832

Browse Source 
It's better to use '= default;' syntax instead of empty constructor and destructor body.
Using '= default;' can help the compiler generate more optimal code.

Reported by: PVS-Studio

Signed-off-by: Vyacheslav Ivanov <islavaivanov76@gmail.com>
This commit is contained in:
Vyacheslav Ivanov
2024-08-03 17:44:10 +03:00
committed by MihailRis
parent c858913a2f
commit aecd0f5db9
32 changed files with 38 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/audio/audio.cpp
+3 -3
View File
@@ -266,7 +266,7 @@ speakerid_t audio::play(
}
auto speaker = speaker_ptr.get();
speakerid_t id = nextId++;
speakers.emplace(id, std::move(speaker_ptr));
speakers.try_emplace(id, std::move(speaker_ptr));
speaker->setPosition(position);
speaker->setVolume(volume);
speaker->setPitch(pitch);
@@ -295,8 +295,8 @@ speakerid_t audio::play(
}
auto speaker = speaker_ptr.get();
speakerid_t id = nextId++;
streams.emplace(id, stream);
speakers.emplace(id, std::move(speaker_ptr));
streams.try_emplace(id, stream);
speakers.try_emplace(id, std::move(speaker_ptr));
stream->bindSpeaker(id);
speaker->setPosition(position);