fix: optimization: PVS-Studio warning V832
It's better to use '= default;' syntax instead of empty constructor and destructor body. Using '= default;' can help the compiler generate more optimal code. Reported by: PVS-Studio Signed-off-by: Vyacheslav Ivanov <islavaivanov76@gmail.com>
This commit is contained in:
committed by
MihailRis
parent
c858913a2f
commit
aecd0f5db9
@@ -46,8 +46,7 @@ Content::Content(
|
||||
}
|
||||
}
|
||||
|
||||
Content::~Content() {
|
||||
}
|
||||
Content::~Content() = default;
|
||||
|
||||
const rigging::SkeletonConfig* Content::getSkeleton(const std::string& id) const {
|
||||
auto found = skeletons.find(id);
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
#include "../objects/rigging.hpp"
|
||||
|
||||
ContentBuilder::~ContentBuilder() {}
|
||||
ContentBuilder::~ContentBuilder() = default;
|
||||
|
||||
void ContentBuilder::add(std::unique_ptr<ContentPackRuntime> pack) {
|
||||
packs[pack->getId()] = std::move(pack);
|
||||
|
||||
@@ -142,5 +142,4 @@ ContentPackRuntime::ContentPackRuntime(
|
||||
{
|
||||
}
|
||||
|
||||
ContentPackRuntime::~ContentPackRuntime() {
|
||||
}
|
||||
ContentPackRuntime::~ContentPackRuntime() = default;
|
||||
|
||||
@@ -5,8 +5,7 @@
|
||||
#include <queue>
|
||||
#include <sstream>
|
||||
|
||||
PacksManager::PacksManager() {
|
||||
}
|
||||
PacksManager::PacksManager() = default;
|
||||
|
||||
void PacksManager::setSources(std::vector<fs::path> sources) {
|
||||
this->sources = sources;
|
||||
@@ -19,7 +18,7 @@ void PacksManager::scan() {
|
||||
for (auto& folder : sources) {
|
||||
ContentPack::scanFolder(folder, packsList);
|
||||
for (auto& pack : packsList) {
|
||||
packs.emplace(pack.id, pack);
|
||||
packs.try_emplace(pack.id, pack);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user