Revert "fix: optimization: Various PVS-Studio warnings"

src/logic/scripting/lua/libconsole.cpp

@@ -75,7 +75,7 @@ static int l_get_command_info(lua::State* L) {
     
     lua::createtable(L, args.size(), 0);
     for (size_t i = 0; i < args.size(); i++) {
-        auto& arg = args[i];
+        auto& arg = args.at(i);
         lua::createtable(L, 0, 2);
         
         lua::pushstring(L, arg.name);

src/logic/scripting/lua/libgui.cpp

@@ -324,6 +324,8 @@ static int l_gui_getattr(lua::State* L) {
     auto docname = lua::require_string(L, 1);
     auto element = lua::require_string(L, 2);
     auto attr = lua::require_string(L, 3);
+    auto docnode = getDocumentNode(L, docname, element);
+    auto node = docnode.node;
 
     static const std::unordered_map<std::string_view, std::function<int(UINode*,lua::State*)>> getters {
         {"color", p_get_color},
@@ -365,8 +367,6 @@ static int l_gui_getattr(lua::State* L) {
     };
     auto func = getters.find(attr);
     if (func != getters.end()) {
-        auto docnode = getDocumentNode(L, docname, element);
-        auto node = docnode.node;
         return func->second(node.get(), L);
     }
     return 0;

src/logic/scripting/lua/libpack.cpp

@@ -95,7 +95,7 @@ static int l_pack_get_info(lua::State* L, const ContentPack& pack, const Content
     if (!pack.dependencies.empty()) {
         lua::createtable(L, pack.dependencies.size(), 0);
         for (size_t i = 0; i < pack.dependencies.size(); i++) {
-            auto& dpack = pack.dependencies[i];
+            auto& dpack = pack.dependencies.at(i);
             std::string prefix;
             switch (dpack.level) {
                 case DependencyLevel::required: prefix = "!"; break;
@@ -142,7 +142,7 @@ static int l_pack_get_info(lua::State* L) {
         manager.scan();
         auto vec = manager.getAll({packid});
         if (!vec.empty()) {
-            return l_pack_get_info(L, vec[0], content);
+            return l_pack_get_info(L, vec.at(0), content);
         }
         return 0;
     }

src/logic/scripting/lua/lua_util.hpp

@@ -151,20 +151,20 @@ namespace lua {
         return 3;
     }
 
-    inline int pushivec3_stack(lua::State* L, const glm::ivec3 &vec) {
+    inline int pushivec3_stack(lua::State* L, glm::ivec3 vec) {
         pushinteger(L, vec.x);
         pushinteger(L, vec.y);
         pushinteger(L, vec.z);
         return 3;
     }
 
-    inline int pushvec3_stack(lua::State* L, const glm::vec3 &vec) {
+    inline int pushvec3_stack(lua::State* L, glm::vec3 vec) {
         pushnumber(L, vec.x);
         pushnumber(L, vec.y);
         pushnumber(L, vec.z);
         return 3;
     }
-    inline int pushvec4_stack(lua::State* L, const glm::vec4 &vec) {
+    inline int pushvec4_stack(lua::State* L, glm::vec4 vec) {
         pushnumber(L, vec.x);
         pushnumber(L, vec.y);
         pushnumber(L, vec.z);
@@ -179,15 +179,15 @@ namespace lua {
         lua_pushvalue(L, idx);
         return 1;
     }
-    inline int pushvec2(lua::State* L, const glm::vec2 &vec) {
+    inline int pushvec2(lua::State* L, glm::vec2 vec) {
         return pushvec(L, vec);
     }
 
-    inline int pushvec3(lua::State* L, const glm::vec3 &vec) {
+    inline int pushvec3(lua::State* L, glm::vec3 vec) {
         return pushvec(L, vec);
     }
 
-    inline int pushvec4(lua::State* L, const glm::vec4 &vec) {
+    inline int pushvec4(lua::State* L, glm::vec4 vec) {
         return pushvec(L, vec);
     }
     inline int pushcolor(lua::State* L, glm::vec4 vec) {
@@ -210,7 +210,7 @@ namespace lua {
         }
         return 1;
     }
-    inline int pushmat4(lua::State* L, const glm::mat4 &matrix) {
+    inline int pushmat4(lua::State* L, glm::mat4 matrix) {
         createtable(L, 16, 0);
         for (uint y = 0; y < 4; y++) {
             for (uint x = 0; x < 4; x++) {
@@ -222,7 +222,7 @@ namespace lua {
         return 1;
     }
     /// @brief pushes matrix table to the stack and updates it with glm matrix 
-    inline int setmat4(lua::State* L, int idx, const glm::mat4 &matrix) {
+    inline int setmat4(lua::State* L, int idx, glm::mat4 matrix) {
         pushvalue(L, idx);
         for (uint y = 0; y < 4; y++) {
             for (uint x = 0; x < 4; x++) {