memory-related refactor

src/content/Content.hpp

@@ -1,17 +1,19 @@
 #ifndef CONTENT_CONTENT_HPP_
 #define CONTENT_CONTENT_HPP_
 
+#include "../typedefs.hpp"
+
 #include <string>
 #include <vector>
 #include <memory>
 #include <stdexcept>
 #include <unordered_map>
 #include <set>
-#include "../typedefs.hpp"
-#include "../voxels/Block.hpp"
 
 using DrawGroups = std::set<ubyte>;
 
+class Block;
+struct BlockMaterial;
 class ItemDef;
 class Content;
 class ContentPackRuntime;
@@ -41,33 +43,6 @@ public:
     }
 };
 
-class ContentBuilder {
-    std::unordered_map<std::string, Block*> blockDefs;
-    std::vector<std::string> blockIds;
-
-    std::unordered_map<std::string, ItemDef*> itemDefs;
-    std::vector<std::string> itemIds;
-
-    std::unordered_map<std::string, BlockMaterial> blockMaterials;
-
-    std::unordered_map<std::string, std::unique_ptr<ContentPackRuntime>> packs;
-public:
-    ~ContentBuilder();
-
-    void add(Block* def);
-    void add(ItemDef* def);
-    void add(ContentPackRuntime* pack);
-    void add(BlockMaterial material);
-
-    Block& createBlock(std::string id);
-    ItemDef& createItem(std::string id);
-
-    void checkIdentifier(std::string id);
-    contenttype checkContentType(std::string id);
-
-    Content* build();
-};
-
 /// @brief Runtime defs cache: indices
 class ContentIndices {
     std::vector<Block*> blockDefs;
@@ -110,21 +85,21 @@ public:
 
 /* Content is a definitions repository */
 class Content {
-    std::unordered_map<std::string, Block*> blockDefs;
-    std::unordered_map<std::string, ItemDef*> itemDefs;
+    std::unordered_map<std::string, std::unique_ptr<Block>> blockDefs;
+    std::unordered_map<std::string, std::unique_ptr<ItemDef>> itemDefs;
     std::unique_ptr<ContentIndices> indices;
     std::unordered_map<std::string, std::unique_ptr<ContentPackRuntime>> packs;
-    std::unordered_map<std::string, BlockMaterial> blockMaterials;
+    std::unordered_map<std::string, std::unique_ptr<BlockMaterial>> blockMaterials;
 public:
     std::unique_ptr<DrawGroups> const drawGroups;
 
     Content(
-        ContentIndices* indices, 
+        std::unique_ptr<ContentIndices> indices, 
         std::unique_ptr<DrawGroups> drawGroups,
-        std::unordered_map<std::string, Block*> blockDefs,
-        std::unordered_map<std::string, ItemDef*> itemDefs,
+        std::unordered_map<std::string, std::unique_ptr<Block>> blockDefs,
+        std::unordered_map<std::string, std::unique_ptr<ItemDef>> itemDefs,
         std::unordered_map<std::string, std::unique_ptr<ContentPackRuntime>> packs,
-        std::unordered_map<std::string, BlockMaterial> blockMaterials
+        std::unordered_map<std::string, std::unique_ptr<BlockMaterial>> blockMaterials
     );
     ~Content();
 
@@ -142,7 +117,7 @@ public:
 
     const ContentPackRuntime* getPackRuntime(std::string id) const;
 
-    const std::unordered_map<std::string, BlockMaterial>& getBlockMaterials() const;
+    const std::unordered_map<std::string, std::unique_ptr<BlockMaterial>>& getBlockMaterials() const;
     const std::unordered_map<std::string, std::unique_ptr<ContentPackRuntime>>& getPacks() const;
 };