fix: optimization: PVS-Studio warning V807

Created references to avoid using repeated expressions, improving performance across multiple instances.

Reported by: PVS-Studio
Signed-off-by: Vyacheslav Ivanov <islavaivanov76@gmail.com>

src/logic/ChunksController.cpp

@@ -113,21 +113,22 @@ bool ChunksController::buildLights(const std::shared_ptr<Chunk>& chunk) {
 void ChunksController::createChunk(int x, int z) {
     auto chunk = level->chunksStorage->create(x, z);
     chunks->putChunk(chunk);
+    auto& chunkFlags = chunk->flags;
 
-    if (!chunk->flags.loaded) {
+    if (!chunkFlags.loaded) {
         generator->generate(
             chunk->voxels, x, z, 
             level->getWorld()->getSeed()
         );
-        chunk->flags.unsaved = true;
+        chunkFlags.unsaved = true;
     }
     chunk->updateHeights();
 
-    if (!chunk->flags.loadedLights) {
+    if (!chunkFlags.loadedLights) {
         Lighting::prebuildSkyLight(
             chunk.get(), level->content->getIndices()
         );
     }
-    chunk->flags.loaded = true;
-    chunk->flags.ready = true;
+    chunkFlags.loaded = true;
+    chunkFlags.ready = true;
 }

src/logic/LevelController.cpp

@@ -47,11 +47,12 @@ void LevelController::update(float delta, bool input, bool pause) {
     player->postUpdate(delta, input, pause);
 
     // erease null pointers
-    level->objects.erase(
+    auto& objects = level->objects;
+    objects.erase(
         std::remove_if(
-            level->objects.begin(), level->objects.end(),
+            objects.begin(), objects.end(),
             [](auto obj) { return obj == nullptr; }),
-        level->objects.end()
+        objects.end()
     );
 }